Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[promptflow-evals] Switch to use AzureOpenAIModelConfiguration for built-in evaluators #2808

Merged
merged 7 commits into from
Apr 16, 2024
Merged

[promptflow-evals] Switch to use AzureOpenAIModelConfiguration for built-in evaluators #2808

merged 7 commits into from
Apr 16, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Apr 16, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

promptflow-core test result

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 69f3bac. ± Comparison against base commit 9f51888.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result users/ninhu/evals_e2e_test2

  4 files    4 suites   4m 51s ⏱️
219 tests 191 ✅  28 💤 0 ❌
876 runs  764 ✅ 112 💤 0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

SDK CLI Global Config Test Result users/ninhu/evals_e2e_test2

4 tests   4 ✅  1m 11s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Executor Unit Test Result users/ninhu/evals_e2e_test2

778 tests   778 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Executor E2E Test Result users/ninhu/evals_e2e_test2

238 tests   236 ✅  7m 5s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

SDK CLI Test Result users/ninhu/evals_e2e_test2

    4 files      4 suites   53m 41s ⏱️
  595 tests   574 ✅ 21 💤 0 ❌
2 380 runs  2 296 ✅ 84 💤 0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

promptflow-evals test result

 12 files   12 suites   1m 55s ⏱️
 18 tests  18 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit 69f3bac.

♻️ This comment has been updated with latest results.

@ninghu ninghu marked this pull request as ready for review April 16, 2024 03:40
@ninghu ninghu requested review from a team as code owners April 16, 2024 03:40
@ninghu ninghu merged commit 45337f2 into main Apr 16, 2024
80 checks passed
@ninghu ninghu deleted the users/ninhu/evals_e2e_test2 branch April 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@nagkumar91 nagkumar91 nagkumar91 approved these changes

@lalala123123 lalala123123 Awaiting requested review from lalala123123

@D-W- D-W- Awaiting requested review from D-W-

Assignees
No one assigned
Labels
fundamental promptflow-core promptflow-evals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninghu @nagkumar91 @wangchao1230